Fix backflow scenario tests#5438
Merged
premun merged 2 commits intodotnet:mainfrom Nov 7, 2025
Merged
Conversation
- The VMR URI was set to dotnet/dotnet and never set the maestro-auth-test/vmr so it probably runs fine in PROD but tests were failing. - Also we had an extra recreation loop that didn't do anything. dotnet#5362
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes off-by-one errors in the VMR codeflow logic and ensures VmrUri is properly set during VMR preparation. The changes address bugs where rewinding to previous flows would not reach the correct depth and where VmrUri could be uninitialized in certain code paths.
- Fixed loop conditions to iterate the correct number of times when rewinding to previous flows
- Ensured VmrUri is set during VMR preparation to prevent null/default values in downstream operations
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Microsoft.DotNet.Darc/DarcLib/VirtualMonoRepo/VmrForwardFlower.cs | Fixed loop condition from i < depth to i <= depth to correctly rewind to the nth previous flow |
| src/Microsoft.DotNet.Darc/DarcLib/VirtualMonoRepo/VmrBackflower.cs | Fixed loop condition from i < depth to i <= depth to correctly rewind to the nth previous flow |
| src/Microsoft.DotNet.Darc/DarcLib/VirtualMonoRepo/VmrCloneManager.cs | Added assignment of VmrUri to ensure it's properly initialized during VMR preparation |
dkurepa
reviewed
Nov 6, 2025
dkurepa
previously approved these changes
Nov 6, 2025
dkurepa
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5362