Only tag PRs when the PR is merged, otherwise just list them#5417
Merged
dkurepa merged 5 commits intodotnet:mainfrom Nov 3, 2025
Merged
Only tag PRs when the PR is merged, otherwise just list them#5417dkurepa merged 5 commits intodotnet:mainfrom
dkurepa merged 5 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to tag forward-flown PRs in code flow updates by extracting and commenting on PRs included in the flow. The implementation refactors PR extraction logic into a shared utility and adds commit retrieval capabilities.
Key changes:
- Extracts commit titles between two SHAs and identifies PRs in GitHub and Azure DevOps
- Tags forward-flown PRs in merged forward flow PRs with a comment listing the included PRs
- Refactors PR number extraction from commit messages into a reusable
GitRepoUtilshelper
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| PullRequestUpdater.cs | Adds TagForwardFlownPRs method to identify and comment on forward-flown PRs; refactors previous SHA retrieval; stores PreviousSourceSha in PR state |
| InProgressPullRequest.cs | Adds PreviousSourceSha property to track the previous source commit SHA |
| VmrForwardFlower.cs | Refactors PR extraction logic to use the new GitRepoUtils.ExtractPullRequestUrisFromCommitTitles helper |
| GitRepoUtils.cs | New utility class that extracts PR URIs from commit titles for both GitHub and Azure DevOps |
| Remote.cs | Adds GetCommitTitlesBetween method to retrieve commit titles between two commits |
| IRemote.cs | Adds interface definition for GetCommitTitlesBetween |
| IRemoteGitRepo.cs | Adds interface definition for GetCommitTitlesBetween |
| GitHubClient.cs | Implements GetCommitTitlesBetween for GitHub using the Compare API |
| AzureDevOpsClient.cs | Implements GetCommitTitlesBetween for Azure DevOps using the commitsBatch API |
Comments suppressed due to low confidence (1)
src/ProductConstructionService/ProductConstructionService.DependencyFlow/PullRequestUpdater.cs:1157
- Variable pr may be null at this access as suggested by this null check.
Variable pr may be null at this access as suggested by this null check.
Variable pr may be null at this access as suggested by this null check.
Variable pr may be null at this access as suggested by this null check.
Variable pr may be null at this access as suggested by this null check.
Variable pr may be null at this access as suggested by this null check.
pr.Url,
Co-authored-by: Copilot <[email protected]>
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Member
Author
|
This is what the comments end up looking like maestro-auth-test/maestro-test-vmr#4343 |
premun
reviewed
Nov 3, 2025
premun
approved these changes
Nov 3, 2025
dkurepa
added a commit
to dkurepa/arcade-services
that referenced
this pull request
Nov 12, 2025
…otnet#5417)" This reverts commit 29657e1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5263