Don't open the darc popup if target-directory or source-directory are provided#5357
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes a UX issue where the DARC tool would unnecessarily open an interactive popup even when target-directory or source-directory options were provided via command line. This improves the user experience when updating subscriptions programmatically.
- Adds checks for TargetDirectory and SourceDirectory options to prevent popup when these are specified
- Enhances the command-line detection logic to be more comprehensive
…eration.cs Co-authored-by: Copilot <[email protected]>
premun
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5220
a small UX fix that makes updating subscriptions a better experience