Link PRs in Forward Flows#5355
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements functionality to link pull requests in forward flow operations within the Product Construction Service. The change enables the system to extract PR numbers from commit messages and add comments with PR links to forward flow operations.
- Adds PR number extraction logic for both GitHub and Azure DevOps repositories using regex patterns
- Updates forward flow process to comment included PRs when meaningful changes are detected
- Modifies scenario tests to verify PR linking functionality works correctly
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/Microsoft.DotNet.Darc/DarcLib/VirtualMonoRepo/VmrForwardFlower.cs |
Implements core PR linking functionality with regex extraction and comment generation |
test/ProductConstructionService.ScenarioTests/ScenarioTests/ScenarioTests_CodeFlow.cs |
Adds test validation for PR linking in forward flow scenarios |
test/ProductConstructionService.ScenarioTests/CodeFlowScenarioTestBase.cs |
Updates test infrastructure to support PR comment verification |
test/Microsoft.DotNet.DarcLib.Codeflow.Tests/ForwardFlowTests.cs |
Removes trailing whitespace |
Comment on lines
+68
to
+74
| // Regex to extract PR number from a github merge commit message | ||
| // e.g.: "Update dependencies from source-repo (#12345)" extracts "12345" | ||
| private readonly static Regex GitHubPullRequestNumberExtractionRegex = new Regex(".+\\(#(\\d+)\\)$"); | ||
|
|
||
| // Regex to extract PR number from an AzDO merge commit message | ||
| // e.g.: "Merged PR 12345: Update dependencies from source-repo" extracts "12345" | ||
| private readonly static Regex AzDoPullRequestNumberExtractionRegex = new Regex("^Merged PR (\\d+):"); |
There was a problem hiding this comment.
Corrected spelling of 'github' to 'GitHub' in comment.
|
|
||
| // Regex to extract PR number from a github merge commit message | ||
| // e.g.: "Update dependencies from source-repo (#12345)" extracts "12345" | ||
| private readonly static Regex GitHubPullRequestNumberExtractionRegex = new Regex(".+\\(#(\\d+)\\)$"); |
There was a problem hiding this comment.
Consider using RegexOptions.Compiled for these static regex patterns to improve performance, or use the newer source generator approach with [GeneratedRegex] attribute for better performance and compile-time validation.
Comment on lines
+70
to
+74
| private readonly static Regex GitHubPullRequestNumberExtractionRegex = new Regex(".+\\(#(\\d+)\\)$"); | ||
|
|
||
| // Regex to extract PR number from an AzDO merge commit message | ||
| // e.g.: "Merged PR 12345: Update dependencies from source-repo" extracts "12345" | ||
| private readonly static Regex AzDoPullRequestNumberExtractionRegex = new Regex("^Merged PR (\\d+):"); |
There was a problem hiding this comment.
Consider using RegexOptions.Compiled for these static regex patterns to improve performance, or use the newer source generator approach with [GeneratedRegex] attribute for better performance and compile-time validation.
Suggested change
| private readonly static Regex GitHubPullRequestNumberExtractionRegex = new Regex(".+\\(#(\\d+)\\)$"); | |
| // Regex to extract PR number from an AzDO merge commit message | |
| // e.g.: "Merged PR 12345: Update dependencies from source-repo" extracts "12345" | |
| private readonly static Regex AzDoPullRequestNumberExtractionRegex = new Regex("^Merged PR (\\d+):"); | |
| private readonly static Regex GitHubPullRequestNumberExtractionRegex = new Regex(".+\\(#(\\d+)\\)$", RegexOptions.Compiled); | |
| // Regex to extract PR number from an AzDO merge commit message | |
| // e.g.: "Merged PR 12345: Update dependencies from source-repo" extracts "12345" | |
| private readonly static Regex AzDoPullRequestNumberExtractionRegex = new Regex("^Merged PR (\\d+):", RegexOptions.Compiled); |
adamzip
reviewed
Oct 10, 2025
premun
reviewed
Oct 10, 2025
premun
reviewed
Oct 10, 2025
premun
approved these changes
Oct 13, 2025
Member
Author
|
|
Member
Author
|
dotnet/dnceng-shared#106 test2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5263