Darc vmr commands should use darc tmp folder#5349
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies Darc VMR commands to use a dedicated "darc-clones" subdirectory within the system's temp folder instead of using the temp folder directly for cloning repositories.
- Introduces a constant for the default Darc clones directory name
- Updates VMR command options to use the dedicated subdirectory for temporary operations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Microsoft.DotNet.Darc/Darc/Constants.cs | Adds constant DefaultDarcClonesDirectoryName with value "darc-clones" |
| src/Microsoft.DotNet.Darc/Darc/Options/VirtualMonoRepo/VmrCommandLineOptionsBase.cs | Updates temp path logic to use darc-clones subdirectory and adds required import |
premun
approved these changes
Oct 8, 2025
premun
reviewed
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5134