Allow darc update-dependencies to update specific VMR folders with target-directory#5340
Merged
dkurepa merged 9 commits intoOct 7, 2025
Merged
Conversation
dkurepa
changed the title
darc update-dependencies to update specific VMR folders with target-directory
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces enhancements to dependency update functionality, adding support for targeting specific directories (including simple globbing) and excluding assets per directory, along with related refactoring to modularize update logic and extend asset matching.
- Added per-directory dependency update workflow with optional glob expansion and root/path handling.
- Introduced asset exclusion with relative path-aware matching and refactored update logic into smaller helper methods.
- Extended APIs (IAssetMatcher, Local.UpdateDependenciesAsync) and added new command-line options (target-directory, excluded-assets).
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| AssetMatcher.cs | Added path-aware exclusion overload to matcher interface and implementation. |
| Local.cs | Extended UpdateDependenciesAsync to support relative base paths and adjusted eng/common file path rewriting. |
| UpdateDependenciesCommandLineOptions.cs | Added target-directory and excluded-assets options with help text. |
| UpdateDependenciesOperation.cs | Major refactor: directory-scoped update flow, asset exclusion integration, task reuse, and decomposition into helper methods. |
Comment on lines
+120
to
+132
| string pathToReplaceWith; | ||
| if (relativeDependencyBasePath == UnixPath.Empty) | ||
| { | ||
| pathToReplaceWith = null; | ||
| } | ||
| else | ||
| { | ||
| pathToReplaceWith = relativeDependencyBasePath.ToString(); | ||
| } | ||
|
|
||
| engCommonFiles = engCommonFiles | ||
| .Select(f => new GitFile( | ||
| f.FilePath.Replace("src/arcade/", null), | ||
| f.FilePath.Replace(VmrInfo.ArcadeRepoDir, pathToReplaceWith, StringComparison.InvariantCultureIgnoreCase).TrimStart('/'), |
There was a problem hiding this comment.
pathToReplaceWith can be null, which will cause string.Replace to throw an ArgumentNullException. Use string.Empty instead of null when you intend to remove the prefix.
Comment on lines
+341
to
+344
| if (nonCoherencyResult != Constants.SuccessCode) | ||
| { | ||
| _logger.LogError(" Failed to update non-coherent parent tied dependencies."); | ||
| return; |
There was a problem hiding this comment.
On failure this method logs and returns without propagating an error, allowing the caller to continue and potentially perform coherency updates on stale data. Consider throwing or returning a status so the caller can abort the directory update.
premun
reviewed
Oct 6, 2025
Co-authored-by: Copilot <[email protected]>
…eration.cs Co-authored-by: Copilot <[email protected]>
…ndLineOptions.cs Co-authored-by: Přemek Vysoký <[email protected]>
premun
approved these changes
Oct 7, 2025
Member
|
@dkurepa I'm seeing some issues with darc that look related to the changes in this PR: |
Member
Author
|
Thanks for catching this @ellahathaway. I made a regression in one of the commits and didn't test that code path with no excluded assets. Opened a PR to fix it #5347 |
This was referenced Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5221