Make HeadBranchSha property optional#5328
Merged
Merged
Conversation
This broke deserialization of redis objects that don't have this property yet. We don't really use it yet, will use it more in future so making it non-required for the time being.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Makes HeadBranchSha non-required to restore deserialization of previously persisted (Redis) objects that do not contain this property yet.
- Removed the required modifier from HeadBranchSha to allow older cached data to deserialize.
- No accompanying nullability or documentation update to reflect new optional status.
pavel-purma
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This broke deserialization of redis objects that don't have this property yet.
We don't really use it yet, will use it more in future so making it non-required for the time being.
#5325