Only reset remotes when fetching branches#5316
Merged
Merged
Conversation
Introduced in dotnet#5315
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where git operations were attempting to reset remotes even when working with non-branch refs (like tags or commit SHAs). The change adds a guard condition to only perform remote reset operations when an upstream branch actually exists.
Key changes:
- Added a null/empty check for upstream branch before attempting reset operations
- Removed redundant field declarations and assignments in PcsVmrBackFlower
- Updated documentation to remove obsolete parameter reference
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| PcsVmrBackFlower.cs | Removed duplicate field declarations that were already handled by base class |
| RepositoryCloneManager.cs | Updated documentation to remove reference to removed parameter |
| CloneManager.cs | Added null check for upstream branch before reset operations to prevent errors with non-branch refs |
Co-authored-by: Copilot <[email protected]>
adamzip
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced in #5315 where we started resetting more even when checking out a SHA but it makes no sense to reset a SHA