Fix Darc subscription creation bugs around target-directory#5294
Merged
dkurepa merged 1 commit intodotnet:mainfrom Sep 22, 2025
Merged
Fix Darc subscription creation bugs around target-directory#5294dkurepa merged 1 commit intodotnet:mainfrom
dkurepa merged 1 commit intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes a subscription creation bug where disabling the source flow incorrectly cleared the target directory. The change now only nulls SourceDirectory when source flow is disabled, preserving TargetDirectory.
- Stop clearing TargetDirectory when source flow is disabled.
- Update accompanying comment to reflect new behavior.
adamzip
approved these changes
Sep 22, 2025
premun
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a leftover bug from #5220 around dependency flow subscription creation, with target-directories