Skip to content

Fix BarViz debugging#5276

Merged
oleksandr-didyk merged 1 commit intodotnet:mainfrom
oleksandr-didyk:dev/fix-barviz-debug
Sep 17, 2025
Merged

Fix BarViz debugging#5276
oleksandr-didyk merged 1 commit intodotnet:mainfrom
oleksandr-didyk:dev/fix-barviz-debug

Conversation

@oleksandr-didyk
Copy link
Copy Markdown
Contributor

Change DebugType compiler prop to fix BarViz not being debuggable in VS and VS Code

Copilot AI review requested due to automatic review settings September 17, 2025 12:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes debugging issues with the BarViz project by changing the compiler debug type configuration from "Full" to "portable" to enable proper debugger connection in Visual Studio and VS Code.

  • Updates DebugType compiler property from "Full" to "portable"
  • Adds DebugSymbols property set to true for complete debug symbol generation
  • Updates documentation comments with Microsoft reference and clearer explanation

Comment thread Directory.Build.props
Comment on lines +38 to +40
If set to anything but `portable` VS and VS Code will fail to connect to a running BarViz debug process
due to maybe some missing debug symbols or attributes. Either way the documentation linked also recommends having
`portable` instead of `full`, so no harm should be done
Copy link

Copilot AI Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment contains uncertain language ('maybe some missing debug symbols') and informal tone ('Either way', 'so no harm should be done'). Consider rewriting with more definitive technical language, such as: 'Setting to portable ensures compatibility with modern debuggers in VS and VS Code. The portable format is the recommended debug format per Microsoft documentation.'

Suggested change
If set to anything but `portable` VS and VS Code will fail to connect to a running BarViz debug process
due to maybe some missing debug symbols or attributes. Either way the documentation linked also recommends having
`portable` instead of `full`, so no harm should be done
Setting `DebugType` to `portable` ensures compatibility with modern debuggers in Visual Studio and VS Code.
The Microsoft documentation linked above recommends using the `portable` format instead of `full`.
This setting is required for reliable debugging of the BarViz project.

Copilot uses AI. Check for mistakes.
Comment thread Directory.Build.props
`portable` instead of `full`, so no harm should be done
-->
<DebugType>Full</DebugType>
<DebugType>portable</DebugType>
Copy link

Copilot AI Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value should be capitalized as 'Portable' to match standard MSBuild property value conventions, similar to how the previous value was 'Full' rather than 'full'.

Suggested change
<DebugType>portable</DebugType>
<DebugType>Portable</DebugType>

Copilot uses AI. Check for mistakes.
@oleksandr-didyk oleksandr-didyk merged commit 8bd00ee into dotnet:main Sep 17, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants