Skip to content

Add es-metadata.yml configuration file#5268

Merged
premun merged 2 commits into
mainfrom
premun-patch-1
Sep 12, 2025
Merged

Add es-metadata.yml configuration file#5268
premun merged 2 commits into
mainfrom
premun-patch-1

Conversation

@premun

@premun premun commented Sep 12, 2025

Copy link
Copy Markdown
Member

Copilot AI review requested due to automatic review settings September 12, 2025 07:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an es-metadata.yml configuration file to the repository, which appears to be a metadata configuration for Enterprise Services (ES) management. This is a port from an Azure DevOps pull request.

Comment thread es-metadata.yml Outdated
Comment thread es-metadata.yml Outdated
@premun premun merged commit e1517f6 into main Sep 12, 2025
5 of 9 checks passed
@premun premun deleted the premun-patch-1 branch September 12, 2025 08:15
Comment thread es-metadata.yml
routing:
defaultAreaPath:
org: dnceng
path: "internal\.NET Product Construction Services"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@premun shouldn't this use a single-quoted string to ensure the backslash isn't treated as an escape?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the original version without any quotes would work as well, looks like Copilot was wrong there

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked Matt's PR in VMR and followed the style there 😅
Backslashes make me uneasy, yeah

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think his and this one is wrong, every yaml parser I paste it into says it's invalid yml 😄

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you're right, fixing this. Too bad this is now an example in the email 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants