Dependency flow can target specific directories#5250
Merged
Conversation
dkurepa
changed the title
dkurepa
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for dependency flow subscriptions to target specific directories rather than just the repository root. This allows for more granular control over where dependency updates are applied within a repository.
Reviewed Changes
Copilot reviewed 43 out of 43 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ProductConstructionService.DependencyFlow/PullRequestUpdater.cs | Core logic to handle multiple target directories and process dependency updates per directory |
| src/ProductConstructionService.DependencyFlow/PullRequestBuilder.cs | Updates to PR building logic to handle multiple directory updates and commit messages |
| src/ProductConstructionService.DependencyFlow/Model/ | New model classes for directory-specific dependency updates |
| src/Microsoft.DotNet.Darc/DarcLib/Remote.cs | Enhanced remote operations to support relative base paths for dependency operations |
| src/Microsoft.DotNet.Darc/DarcLib/Models/Darc/AssetMatcher.cs | Extended asset matching to work with multiple directories and path-specific filters |
| test/ | Updated test files to support the new directory-based dependency flow functionality |
| tools/ | Updated repro tools to handle target directory parameters |
dkurepa
commented
Sep 8, 2025
premun
reviewed
Sep 8, 2025
premun
reviewed
Sep 8, 2025
Co-authored-by: Přemek Vysoký <[email protected]>
premun
reviewed
Sep 10, 2025
adamzip
reviewed
Sep 10, 2025
Comment on lines
+885
to
+887
| bool isRoot = targetDirectory == UnixPath.Empty; | ||
| List<AssetData> assetData = build.Assets | ||
| .Where(a => !excludedAssetsMatcher.IsExcluded(isRoot ? a.Name : $"{targetDirectory}/{a.Name}")) |
Contributor
There was a problem hiding this comment.
nit (take logical branching out of the loop):
Suggested change
| bool isRoot = targetDirectory == UnixPath.Empty; | |
| List<AssetData> assetData = build.Assets | |
| .Where(a => !excludedAssetsMatcher.IsExcluded(isRoot ? a.Name : $"{targetDirectory}/{a.Name}")) | |
| string directoryPrefix = string.IsNullOrEmpty(targetDirectory) ? "" : $"{targetDirectory}/"; | |
| List<AssetData> assetData = build.Assets | |
| .Where(a => !excludedAssetsMatcher.IsExcluded(directoryPrefix + a.Name)) |
Member
Author
There was a problem hiding this comment.
95% of these updates are going to be in the root directory. I wonder if the branching overhead in the loop beats the overhead of constant string allocation
| .Where(a => !excludedAssetsMatcher.IsExcluded(a.Name)) | ||
| .Select(a => new AssetData(false) | ||
| List<UnixPath> targetDirectories; | ||
| if (string.IsNullOrEmpty(subscription.TargetDirectory)) |
Contributor
There was a problem hiding this comment.
This condition is technically unnecessary. You could remove the if/else and your Split(',') command a few lines under would pick up the empty string for subscription.TargetDirectory and correctly interpret it as UnixPath.Empty when you do targetDirectories.Add(new UnixPath(d));
Member
Author
There was a problem hiding this comment.
if there is no TargetDirectory (for most dependency flow subs), this will cause a null reference exception
premun
reviewed
Sep 11, 2025
premun
reviewed
Sep 11, 2025
premun
previously approved these changes
Sep 11, 2025
…nPopUp.cs Co-authored-by: Přemek Vysoký <[email protected]>
…pUp.cs Co-authored-by: Přemek Vysoký <[email protected]>
premun
reviewed
Sep 11, 2025
Comment on lines
+57
to
+66
| public void UnixPathEqualityTest() | ||
| { | ||
| var emptyPath1 = new UnixPath(""); | ||
| var emptyPath2 = UnixPath.Empty; | ||
| var dotPath = new UnixPath("."); | ||
|
|
||
| (emptyPath1 == emptyPath2).Should().BeTrue(); | ||
| (emptyPath1 == dotPath).Should().BeTrue(); | ||
| (emptyPath2 == dotPath).Should().BeTrue(); | ||
| } |
Member
There was a problem hiding this comment.
Can we have a test for what happens when we do UnixPath.Empty / "foo"? Or when we do new UnixPath("foo") / UnixPath.Empty / "bar"?
Member
Author
There was a problem hiding this comment.
UnixPath.Empty / "foo" return /foo and new UnixPath("foo") / UnixPath.Empty / "bar" returns foo/bar. I'm not sure if the first one is expected, maybe we'd just expect foo there?
premun
approved these changes
Sep 11, 2025
This was referenced Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5220