Inject services instead of passing them as method parameters#4756
Merged
premun merged 5 commits intodotnet:mainfrom Apr 29, 2025
Merged
Inject services instead of passing them as method parameters#4756premun merged 5 commits intodotnet:mainfrom
premun merged 5 commits intodotnet:mainfrom
Conversation
premun
changed the title
Remote and do not pass them as args
premun
changed the title
premun
requested review from
adamzip and
dkurepa
and removed request for
adamzip
dkurepa
approved these changes
Apr 29, 2025
oleksandr-didyk
added a commit
that referenced
this pull request
Sep 17, 2025
<!-- Link the GitHub or AzDO issue this pull request is associated with. Please copy and paste the full URL rather than using the dotnet/arcade-services# syntax --> Change `DebugType` compiler prop to fix BarViz not being debuggable in VS and VS Code <!-- #4756 -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repository was ridden with places where we were passing dependencies as arguments. We have mostly removed that but yesterday during the bug squashing I found few more places where it's then harder to use the classes so improving that.