Ignore mapping disables during non-recursive synchronization#4211
Merged
Conversation
dkurepa
approved these changes
Dec 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4159
This means that we will ignore the flag during forward codeflows which would not otherwise be possible because we want to disable the pipeline sync for a repo always first.
But it's okay to do this because when we want to synchronize a single repository, it doesn't make sense to just refuse to do it because it's toggled off. It does make sense to adhere to this flag during a recursive sync (which happens in the pipeline sync).
Also improves the exception when we can't create a PR.