Clean up clones before usage#4204
Merged
Merged
Conversation
dkurepa
approved these changes
Dec 3, 2024
dkurepa
reviewed
Dec 3, 2024
| { | ||
| _logger.LogWarning("Failed to clean up {clonePath}, re-cloning", clonePath); | ||
| _fileSystem.DeleteDirectory(clonePath, recursive: true); | ||
| return await PrepareCloneInternal(remoteUri, dirName, performCleanup: true, cancellationToken); |
Member
There was a problem hiding this comment.
nit: do we need to reset a freshly cloned repo? it should be a no op
Member
Author
There was a problem hiding this comment.
If it really clones again, it will no go this route anymore but rather through line 139 so it does not really matter what we put there. But I assumed true is better in case of whatever other new case in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4197