Skip to content

Make darc verify codeflow subscriptions not sourcing/targeting VMRs correctly#4203

Merged
premun merged 7 commits into
dotnet:mainfrom
premun:prvysoky/darc-vmr-verification
Dec 3, 2024
Merged

Make darc verify codeflow subscriptions not sourcing/targeting VMRs correctly#4203
premun merged 7 commits into
dotnet:mainfrom
premun:prvysoky/darc-vmr-verification

Conversation

@premun

@premun premun commented Nov 29, 2024

Copy link
Copy Markdown
Member
  • Blocks the user from making a mistake when creating codeflow subscriptions and not sourcing/targeting a VMR correctly.
  • Stops requiring a logger when creating remotes.
  • Uses DI in Darc to obtain a remote factory.

Resolves #4174

@premun premun requested a review from dkurepa November 29, 2024 15:30
@premun premun merged commit 3e47dc3 into dotnet:main Dec 3, 2024
@premun premun deleted the prvysoky/darc-vmr-verification branch December 3, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a check to darc to verify source-enabled subscriptions target/come from a VMR

2 participants