Skip to content

make dnceng tools non packable#2291

Merged
dkurepa merged 7 commits intodotnet:mainfrom
dkurepa:dkurepa/DontPublishDncengTools
May 31, 2023
Merged

make dnceng tools non packable#2291
dkurepa merged 7 commits intodotnet:mainfrom
dkurepa:dkurepa/DontPublishDncengTools

Conversation

@dkurepa
Copy link
Member

@dkurepa dkurepa commented May 23, 2023

@dkurepa
Copy link
Member Author

dkurepa commented May 23, 2023

I think also removing the attribute would do the same thing. This is more explicit tho

@dkurepa
Copy link
Member Author

dkurepa commented May 23, 2023

Monitoring.Sdk is still getting published. I might be because of <PackageType>MSBuildSdk</PackageType> will try to remove

@dkurepa dkurepa requested review from missymessa and riarenas May 24, 2023 17:15
@riarenas
Copy link
Contributor

Will this cause failures in the post-publishing steps of the build since we're still trying to deploy everything from here?

@dkurepa
Copy link
Member Author

dkurepa commented May 25, 2023

I don't think we will. Dotnet.Status.Web doesn't use those packages, and none of the other projects here are used for deployments. To be safe, I can disable the rollouts for all internal tools in this PR too, we planned on doing that anyway

displayName: Notify deployment start
pool: server
steps:
- task: InvokeRESTAPI@1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is OK to remove, since it might be used for Maestro deployments too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was at least necessary for RolloutScorer. Let me know if ProdCon isn't planning to use results from RolloutScorer anymore for Arcade Services and I'll make sure it gets removed from RolloutScorer.

Copy link
Contributor

@riarenas riarenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants