darcbot handling multiple builds#1341
Merged
rokonec merged 8 commits intoAug 13, 2020
Merged
Conversation
premun
reviewed
Aug 12, 2020
premun
left a comment
premun
left a comment
Member
There was a problem hiding this comment.
I mostly only reviewed TimelineIssueTriageService.cs since it seemed to be the important part
Comment on lines
+278
to
+281
| return (!Object.ReferenceEquals(null, compareItem)) && | ||
| (BuildId == compareItem.BuildId) && | ||
| (RecordId == compareItem.RecordId) && | ||
| (Index == compareItem.Index); |
Member
There was a problem hiding this comment.
Suggested change
| return (!Object.ReferenceEquals(null, compareItem)) && | |
| (BuildId == compareItem.BuildId) && | |
| (RecordId == compareItem.RecordId) && | |
| (Index == compareItem.Index); | |
| return !Object.ReferenceEquals(null, compareItem) && | |
| BuildId == compareItem.BuildId && | |
| RecordId == compareItem.RecordId && | |
| Index == compareItem.Index; |
| update.AddLabel(_labelName); | ||
| await gitHubClient.Issue.Update(issuePayload.Repository.Id, issuePayload.Issue.Number, update); | ||
|
|
||
| // add into notification epic -> currently 8/2020 its First Response epic |
Member
There was a problem hiding this comment.
Suggested change
| // add into notification epic -> currently 8/2020 its First Response epic | |
| // add into notification epic -> currently 8/2020 it's First Responder epic |
lpatalas
reviewed
Aug 12, 2020
premun
approved these changes
Aug 13, 2020
lpatalas
approved these changes
Aug 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: https://github.com/dotnet/core-eng/issues/10361