Fix static state bug in ChannelCategorizer causing test failures

Copilot · premun · Copilot · commit 3f68429576aa · 2025-08-26T13:03:52.000Z
Co-authored-by: premun &lt;7013027+premun@users.noreply.github.com&gt;
diff --git a/src/ProductConstructionService/Microsoft.DotNet.ProductConstructionService.Client/Helpers/ChannelCategorizer.cs b/src/ProductConstructionService/Microsoft.DotNet.ProductConstructionService.Client/Helpers/ChannelCategorizer.cs
@@ -14,22 +14,23 @@ namespace Microsoft.DotNet.ProductConstructionService.Client.Helpers
     /// </summary>
     public static class ChannelCategorizer
     {
-        private static readonly Lazy<List<ChannelCategory>> s_categories = new Lazy<List<ChannelCategory>>(() =>
+        private static readonly List<string> s_categoryNames = 
             // .NET 6-20
-            Enumerable.Range(0, 16).Select(v => new ChannelCategory($".NET {20 - v}"))
+            Enumerable.Range(0, 16).Select(v => $".NET {20 - v}")
                 .Concat(new[]
                 {
-                    new ChannelCategory(".NET"),
-                    new ChannelCategory("VS"),
-                    new ChannelCategory("Windows"),
-                    new ChannelCategory("Other"),
-                    new ChannelCategory("Test"),
+                    ".NET",
+                    "VS", 
+                    "Windows",
+                    "Other",
+                    "Test",
                 })
-                .ToList());
+                .ToList();
 
         public static List<ChannelCategory> CategorizeChannels(IEnumerable<Channel> channels)
         {
-            var categories = s_categories.Value;
+            // Create fresh category instances for each call to avoid static state issues
+            var categories = s_categoryNames.Select(name => new ChannelCategory(name)).ToList();
             var otherCategory = categories.First(c => c.Name == "Other");
             var testCategory = categories.First(c => c.Name == "Test");
 
