Fail gracefully when cannot upload test results in Helix SDK#9488
Merged
epananth merged 3 commits intodotnet:mainfrom May 31, 2022
Merged
Fail gracefully when cannot upload test results in Helix SDK#9488epananth merged 3 commits intodotnet:mainfrom
epananth merged 3 commits intodotnet:mainfrom
Conversation
MattGal
previously approved these changes
May 31, 2022
Member
MattGal
left a comment
MattGal
left a comment
There was a problem hiding this comment.
LGTM beyond I don't know what happens when it gets a 0 it doesn't expect.
src/Microsoft.DotNet.Helix/Sdk/CreateFailedTestsForFailedWorkItems.cs
Outdated
Show resolved
Hide resolved
alexperovich
approved these changes
May 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To double check:
Added null check and upped logging to normal
Issue- https://github.com/orgs/dotnet/projects/86/views/4