Skip to content

Conversation

@ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented May 13, 2022

Avoids the hardcoded paths in consuming repositories, i.e. https://github.com/dotnet/runtime/blob/4ecd06037d7dfc5a039911c262ab792d6575d7fc/src/workloads/workloads.csproj#L11-L12

Created the package offline and validated that the contents are in it, as expected. Also cleaned-up unnecessary items/props in the project file.

@ViktorHofer ViktorHofer added the area-Infrastructure-libraries Area maintained by .NET libraries team: APICompat, AsmDiff, GenAPI, GenFacades, PkgProj, etc label May 13, 2022
@ViktorHofer ViktorHofer self-assigned this May 13, 2022
@ViktorHofer ViktorHofer removed the area-Infrastructure-libraries Area maintained by .NET libraries team: APICompat, AsmDiff, GenAPI, GenFacades, PkgProj, etc label May 13, 2022
@ViktorHofer ViktorHofer merged commit e91550a into dotnet:main May 13, 2022
@ViktorHofer ViktorHofer deleted the WorkloadsProps branch May 13, 2022 10:44
akoeplinger added a commit that referenced this pull request May 24, 2022
Include doesn't work there, it should be TaskName. Broken in #9355
akoeplinger added a commit that referenced this pull request May 24, 2022
Include doesn't work there, it should be TaskName. Broken in #9355
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants