Make CodeQL Clean (main) #8537
Merged
Make CodeQL Clean (main) #8537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riarenas
previously approved these changes
Mar 7, 2022
Contributor
riarenas
left a comment
riarenas
left a comment
There was a problem hiding this comment.
I'm not sure what Gitsync is or if this is going to affect it, but everything else lgtm
mmitche
reviewed
Mar 7, 2022
src/Microsoft.DotNet.Build.Tasks.Feed.Tests/BuildModelFactoryTests.cs
Outdated
Show resolved
Hide resolved
mmitche
reviewed
Mar 7, 2022
src/Microsoft.DotNet.Build.Tasks.Feed.Tests/BuildModelFactoryTests.cs
Outdated
Show resolved
Hide resolved
mmitche
reviewed
Mar 7, 2022
mmitche
reviewed
Mar 7, 2022
mmitche
reviewed
Mar 7, 2022
mmitche
reviewed
Mar 7, 2022
mmitche
reviewed
Mar 7, 2022
mmitche
reviewed
Mar 7, 2022
mmitche
reviewed
Mar 7, 2022
mmitche
reviewed
Mar 7, 2022
mmitche
reviewed
Mar 7, 2022
mmitche
reviewed
Mar 7, 2022
src/Microsoft.DotNet.VersionTools/tests/BuildManifest/ManifestModelTests.cs
Outdated
Show resolved
Hide resolved
mmitche
reviewed
Mar 7, 2022
src/Microsoft.DotNet.VersionTools/tests/BuildManifest/ManifestModelTests.cs
Outdated
Show resolved
Hide resolved
mmitche
reviewed
Mar 7, 2022
src/Microsoft.DotNet.VersionTools/tests/BuildManifest/ManifestModelTests.cs
Outdated
Show resolved
Hide resolved
mmitche
reviewed
Mar 7, 2022
src/Microsoft.DotNet.VersionTools/tests/BuildManifest/ManifestModelTests.cs
Outdated
Show resolved
Hide resolved
mmitche
previously approved these changes
Mar 7, 2022
Co-authored-by: Matt Mitchell <[email protected]>
mmitche
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve remaining CodeQL errors.
This build was run against this branch and shows lots of happy green color.
Part of dotnet/core-eng#15545