Skip to content

Fix typo in mac installer generation script #7917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ericstj merged 1 commit into from
Sep 20, 2021
Merged

Fix typo in mac installer generation script #7917

ericstj merged 1 commit into from
Sep 20, 2021

Conversation

@sfoslund
Copy link
Member

@sfoslund sfoslund commented Sep 20, 2021

No description provided.

@sfoslund sfoslund requested a review from ericstj September 20, 2021 16:12
ericstj
ericstj reviewed Sep 20, 2021
View reviewed changes
src/Microsoft.DotNet.Build.Tasks.Installers/src/GenerateMacOSDistributionFile.cs
var archScriptContent = @"<![CDATA[
function IsX64Machine() {
var machine = system.sysctl(""hw.foo"");
var machine = system.sysctl(""hw.machine"");
Copy link
Member

@ericstj ericstj Sep 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we have proof our fallback code works if mac were to ever stop reporting this sysctl.

@ericstj ericstj merged commit f959b45 into main Sep 20, 2021
@sfoslund sfoslund deleted the sfoslund/MacScriptFix branch September 20, 2021 17:28
@danmoseley danmoseley mentioned this pull request Feb 7, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericstj ericstj ericstj approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sfoslund @ericstj