Skip to content

Conversation

@am11
Copy link
Member

@am11 am11 commented Sep 13, 2021

find-native-compiler.sh in arcade and init-compiler.sh in runtime are duplicate scripts. The one in the runtime repo is more up-to-date.

This PR replaces find-native-compiler.sh with copy of init-compiler.sh from runtime repo, so we will need to maintain supported native compilers in just one place, instead of two.

@am11
Copy link
Member Author

am11 commented Sep 13, 2021

cc @jkoritzinsky, @janvorli

e.g. the llvm-ld changes (among other things) are not available in find-native-compiler.sh due to this maintenance overhead.

@am11 am11 force-pushed the feature/native-compiler branch 2 times, most recently from 0878abc to 3d71954 Compare September 13, 2021 07:12
@am11 am11 force-pushed the feature/native-compiler branch from 3d71954 to 157c794 Compare September 13, 2021 07:56
@jkoritzinsky jkoritzinsky merged commit 70afc8b into dotnet:main Sep 13, 2021
@am11 am11 deleted the feature/native-compiler branch September 13, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants