Skip to content

Conversation

@jkoritzinsky
Copy link
Member

To double check:

cc: @jkotas

@jkotas
Copy link
Member

jkotas commented Sep 9, 2021

Is this just a fallback, or is this going to be used in the shipping binaries from Microsoft official builds?

@jkoritzinsky
Copy link
Member Author

This would be the shipping version info. Based on your question, do we want to keep the shipping info the same as it has always been?

If so, I'd like to keep the fallback matching this one as the fallback will only be used on bringup platforms or weirdly built local builds.

@jkotas
Copy link
Member

jkotas commented Sep 9, 2021

We have overrides of these defaults in some places already. For example, coreclr.dll from .NET 6 P7 has product name Microsoft .NET and not Microsoft .NET Framework..

I would change .NET Framework to just .NET here. .NET Framework is not the right default product name for projects using Arcade.

The rest would be larger effort to cleanup. We do not seem to be setup to have proper company-specific labeling on binaries, and cleaning that up would be larger effort. So ignore it for now.

@jkoritzinsky
Copy link
Member Author

Can you take a look at the updated diff and let me know if that looks good?

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkoritzinsky jkoritzinsky enabled auto-merge (squash) September 9, 2021 19:23
@jkoritzinsky jkoritzinsky merged commit fa4a480 into dotnet:main Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants