Use ProductVersion.txt where possible #7837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the inner package from productVersion.txt, NOT from the specified version. Allows "non-stable" outer container with "stable" inner contents dotnet#7836
2 tasks
dougbu
reviewed
Sep 4, 2021
dougbu
reviewed
Sep 4, 2021
dougbu
reviewed
Sep 4, 2021
alexperovich
reviewed
Sep 7, 2021
ChadNedzlek
reviewed
Sep 7, 2021
…k for > 3.1, and when available use the specific-productVersion.txt files (mostly seem to contain the same version)
dougbu
reviewed
Sep 7, 2021
Contributor
dougbu
left a comment
dougbu
left a comment
There was a problem hiding this comment.
I'm really liking the 🔛-by-default approach 😺
ChadNedzlek
approved these changes
Sep 7, 2021
MattGal
changed the title
Contributor
|
@MattGal can this please be ported to 'release/6.0'❔ I don't want to update our 6.0 dependencies to 7.0.0 Arcade bits and 6.0 is where we need this fix first. |
Contributor
|
In the meantime (for the servicing exercise), what's holding up getting this into `.NET Eng - Latest'❔ It appears arcade-official-ci build 20210907.8 went smoothly yesterday. But Maestro says the latest promoted build was 20210907.3. |
Member
Author
Contributor
|
Glad a fix is in hand 😀 And,
|
Member
Author
Yes I'm working on it |
Contributor
|
Many thanks again |
MattGal
added a commit
to MattGal/arcade
that referenced
this pull request
Sep 9, 2021
* Add ProductVersion.txt support where possible; get the version of the inner package from productVersion.txt, NOT from the specified version. Allows "non-stable" outer container with "stable" inner contents dotnet#7836
MattGal
added a commit
that referenced
this pull request
Sep 9, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if DotNetCliUseProductVersion is set to true, get the version of the inner package from productVersion.txt, NOT from the specified version. Allows "non-stable" outer container with "stable" inner contents.
See #7836 for context
To double check: