[workloads] Add locks for parallel NuGet access #7813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android workload pack conversion has been failing intermittently:
Generating package project: 'obj\Debug\src\msiPackage\x86\Microsoft.Android.Sdk.Windows\msi.csproj'
convert.proj(72,5): error : One or more errors occurred.
convert.proj(72,5): error : Failed to generate MSIs for workload packs.
C:\Users\AzDevOps\.nuget\packages\wix\3.14.0-dotnet\tools\heat.exe dir obj\Debug\pkg\Microsoft.Android.Templates.31.0.100-rc.2.14 -cg CG_PackageContent -var var.SourceDir -ag -srd -sreg -dr InstallDir -o obj\Debug\src\msi\Microsoft.Android.Templates\31.0.100-rc.2.14\x64\PackageContent.wxs
##[error]light.exe(0,0): Error LGHT0001: The system cannot find the file specified. (Exception from HRESULT: 0x80070002)
light.exe : error LGHT0001: The system cannot find the file specified. (Exception from HRESULT: 0x80070002) [C:\a\1\s\nuget-msi-convert\convert-v2\convert.proj]
Exception Type: System.IO.FileNotFoundException
Stack Trace:
at Microsoft.Tools.WindowsInstallerXml.Cab.Interop.NativeMethods.CreateCabFinish(IntPtr contextHandle, IntPtr newCabNamesCallBackAddress)
at Microsoft.Tools.WindowsInstallerXml.Cab.WixCreateCab.Complete(IntPtr newCabNamesCallBackAddress)
at Microsoft.Tools.WindowsInstallerXml.CabinetBuilder.CreateCabinet(CabinetWorkItem cabinetWorkItem)
at Microsoft.Tools.WindowsInstallerXml.CabinetBuilder.ProcessWorkItems()
I've added a lock to attempt to synchronize some .nupkg file access that
seemed to be problematic when executing asynchronously.
joeloff
reviewed
Aug 31, 2021
Member
joeloff
left a comment
joeloff
left a comment
There was a problem hiding this comment.
I wonder if we should make a similar change in GenerateManifestMsi
Member
Author
|
It looks like |
Member
|
Oh, yes, because we build like 2 MSIS with that, what was I thinking. |
joeloff
approved these changes
Aug 31, 2021
pjcollins
added a commit
to dotnet/android
that referenced
this pull request
Sep 2, 2021
Context: dotnet/arcade#7813 We've been often seeing .NET 6 msi generation failing after updating to a version of arcade that added parallelization to the msi creation. The latest version of arcade should hopefully fix these issues.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android workload pack conversion has been failing intermittently:
I've added a lock to attempt to synchronize some .nupkg file access that
seemed to be problematic when executing asynchronously.