Update ArPow build to build with current TFM #7674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSimons
approved these changes
Jul 27, 2021
Contributor
Author
|
@tmat, Can your review specifically for the change in |
This reverts commit e38710b.
Don't warn on SYSLIB0013 - Uri.EscapeUriString() is obsolete. This is marked obsolete for net6.0 and changing it to Uri.EscapeDataString() changes behavior. Ignore the warning.
dseefeld
force-pushed
the
updateForSourceBuild
branch
from
553484b to
17bd477
Compare
Because of the update to net6, implicit namespace support is causing a conflict when using Task as a base class.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has 3 items:
runtime.jsoninMicrosoft.DotNet.Build.Tasks.Packaging.csproj. The version ofMicrosoft.NETCore.Platformsis defined via a PVP variable, but the search path was hardcoded to 2.1.0. If a different version ofMicrosoft.NETCore.Platformsis used (as happens in the source-build offline build), the path is incorrect.