[release/5.0] Send System.PullRequest.TargetBranch in job created by SendHelixJob
#7082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattGal
approved these changes
Mar 10, 2021
Contributor
|
@lpatalas as this is a PR to one of the servicing branches, please use the https://github.com/dotnet/arcade/blob/main/Documentation/Policy/AskModeTellModeTemplate.md template for your PR description. (same applies for the release/3.x PR) You will also need explicit approval from either @markwilkie or @mmitche before merging. |
mmitche
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is part of moving servicing jobs to COGS subscription: https://github.com/dotnet/core-eng/issues/11639.
We need to include
System.PullRequest.TargetBranchpipeline variable in Helix job properties to be able to redirect PR test jobs to servicing subscription. Currently Helix API has no way to tell if the PR was created formainorrelease/*branch.I also added other properties that are send in
mainfor consistency.Related issue: #7074
Customer Impact
There is no customer impact. Only effect is that additional properties will be attached to Helix job.
Regression
No
Risk
The risk of this change is very low. Change is very small and the same code already runs on main.
Workarounds
There is no workaround available. Without this change we won't be able to redirect servicing PR test jobs to COGS subscription.