Remove component governance from public CI #7046
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'm ok with these changes, but I'd like to get @lpatalas's opinion since he added the CG task to the builds, and probably knows more about the SDL side of things than I do. |
michellemcdaniel
approved these changes
Mar 3, 2021
Contributor
|
As long as it runs in internal pipeline then it's ok. The only drawback is that if something is reported by the scan we won't know about it during PR build so maybe it would be a good idea to revert it in the future, after the scanner is fixed. |
lpatalas
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes Component Governance from public CI builds which should unblock arcade PRs.
To double check: