Fix flatten exclusion #7036
Merged
Fix flatten exclusion #7036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We weren't passing along the TargetChannelConfig's Flatten designation, so we were flattening when we meant to exclude it.
Closed
MattGal
approved these changes
Mar 1, 2021
Member
|
Do we need a test that will say when flatten was set to false, it does not flatten and when it is set to true it flattens? Idk if it was included in other PR, so want to check anyway. |
epananth
approved these changes
Mar 1, 2021
Member
|
cc: @jander-msft |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
akoeplinger
pushed a commit
to akoeplinger/arcade
that referenced
this pull request
Apr 12, 2021
We weren't passing along the TargetChannelConfig's Flatten designation, so we were flattening when we meant to exclude it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't passing along the TargetChannelConfig's Flatten designation, so we were flattening when we meant to exclude it.
To double check: