Skip to content

Error signalization fix #7034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukas-lansky merged 1 commit into from
Mar 3, 2021
Merged

Error signalization fix #7034

lukas-lansky merged 1 commit into from
Mar 3, 2021

Conversation

@lukas-lansky
Copy link
Contributor

@lukas-lansky lukas-lansky commented Mar 1, 2021 •
edited
Loading

ToolFilePath is always empty here.

I noticed the problem when trying to repeatedly run native toolset bootstrapping in wpf:

C:\Source\wpf> .\eng\common\init-tools-native.cmd
Processing C:\Source\wpf\global.json
strawberry-perl was not found in .
strawberry-perl installation failed

With the patch the error reporting is now:

C:\Source\wpf> .\eng\common\init-tools-native.cmd
Processing C:\Source\wpf\global.json
strawberry-perl was not found in C:\Users\lulansky\.netcoreeng\native\bin\strawberry-perl\5.28.1.1-1\.
strawberry-perl installation failed

There is still the underlying issue, but I'm keeping research of that for another day.

@lukas-lansky lukas-lansky requested a review from riarenas March 1, 2021 14:24
@lukas-lansky lukas-lansky changed the title Error signalization fix (ToolFilePath is always empty here) Error signalization fix Mar 1, 2021
riarenas
riarenas approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@riarenas riarenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Please include details on the issue this change is trying to fix, along with some details on how you validated this fixes what you were seeing.

@lukas-lansky
Copy link
Contributor Author

lukas-lansky commented Mar 3, 2021

Good point, description enhanced.

@lukas-lansky
Copy link
Contributor Author

lukas-lansky commented Mar 3, 2021

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 3, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@lukas-lansky lukas-lansky merged commit 5ca2e7c into dotnet:master Mar 3, 2021
@lukas-lansky lukas-lansky deleted the missing-tool-error-signalization branch March 3, 2021 21:30
akoeplinger pushed a commit to akoeplinger/arcade that referenced this pull request Apr 12, 2021
@lukas-lansky @akoeplinger
Error signalization fix (ToolFilePath is always empty here) (dotnet#7034
45577e6 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@riarenas riarenas riarenas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lukas-lansky @riarenas