Documentation for using MSBuildTaskBase class#6760
Merged
missymessa merged 8 commits intomasterfrom Jan 12, 2021
Merged
Conversation
missymessa
assigned
garath,
MattGal,
mmitche,
michellemcdaniel,
chcosta,
ChadNedzlek and
ghost
missymessa
unassigned
garath,
MattGal,
mmitche,
michellemcdaniel,
chcosta,
ChadNedzlek and
ghost
missymessa
requested review from
a user,
ChadNedzlek,
MattGal,
chcosta,
michellemcdaniel and
mmitche
ChadNedzlek
reviewed
Jan 8, 2021
ChadNedzlek
reviewed
Jan 8, 2021
ChadNedzlek
reviewed
Jan 8, 2021
ChadNedzlek
reviewed
Jan 8, 2021
MattGal
approved these changes
Jan 8, 2021
Member
MattGal
left a comment
MattGal
left a comment
There was a problem hiding this comment.
Good stuff. Does seem to assume the reader attended your brown bag.
ChadNedzlek
reviewed
Jan 8, 2021
ChadNedzlek
reviewed
Jan 8, 2021
ChadNedzlek
reviewed
Jan 8, 2021
ChadNedzlek
reviewed
Jan 8, 2021
ChadNedzlek
reviewed
Jan 8, 2021
ChadNedzlek
approved these changes
Jan 8, 2021
alexperovich
reviewed
Jan 8, 2021
alexperovich
reviewed
Jan 8, 2021
garath
approved these changes
Jan 8, 2021
lukas-lansky
approved these changes
Jan 11, 2021
ghost
approved these changes
Jan 11, 2021
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
I like this! mostly nits, and perhaps some sections could benefit from some more context to be more helpful for first time readers.
Member
Author
Added the links from Chad's DI presentation for further reading about dependency injection. |
…code in base class in the documentation, since we can't embed code in docs :(
Member
Author
|
Whew. Okay, I think I got through everyone's feedback (thank you all!) and created another issue to add some enhancements to the base class (e.g. asyncing the ExecuteTask method; including default services where necessary; improving the logger so that we can use ILogger types). Also did a little bit of refactoring to the tests that I created to make better use of the DI testing functionality. I'll merge this PR sometime tomorrow afternoon if there's no other feedback. |
akoeplinger
pushed a commit
to akoeplinger/arcade
that referenced
this pull request
Apr 12, 2021
* Documentation for using MSBuildTaskBase class * Small changes per feedback * Rewording opening paragraphs and clarifying implementation details * Forgot to save * Refactoring to the tests to use additionalScopedTypes and some doc changes * Changed additionalScopeTypes to additionalSingleTypes; added link to code in base class in the documentation, since we can't embed code in docs :(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation to give instruction on best practices for using the MSBuildTaskBase class and how it works behind the scenes.