Unit tests for SignToolTask#6746
Merged
chcosta merged 4 commits intodotnet:masterfrom Jan 6, 2021
Merged
Conversation
missymessa
reviewed
Jan 6, 2021
missymessa
reviewed
Jan 6, 2021
| [Required] | ||
| public string LogDir { get; set; } | ||
|
|
||
| internal BatchSignInput ParsedSigningInput { get; private set; } |
Member
There was a problem hiding this comment.
I assume that you made this change in the interest of time to get as many tests done as possible. To not have to expose this value, I would have created a factory pattern to create a new BatchSignUtil, so that I could use a mock to verify the value of the signingInput being sent into it.
missymessa
reviewed
Jan 6, 2021
| WixToolsPath = badPath | ||
| }; | ||
|
|
||
| task.Execute(); |
Member
There was a problem hiding this comment.
Do we want to verify that the result of the execute is false? I know we imply that it's false because the log has logged errors in the following assertion, but it would ensure that the results are expected in the event someone decides to refactor the tasks and makes a mistake.
akoeplinger
pushed a commit
to akoeplinger/arcade
that referenced
this pull request
Apr 12, 2021
* Unit tests for SignToolTask * pr feedback: remove unneeded trait * Add comment * pr feedback: test task return value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6365