Skip to content

Conversation

@jkotas
Copy link
Member

@jkotas jkotas commented Nov 12, 2020

No description provided.

@jkotas jkotas requested a review from agocke November 12, 2020 14:43
@jkotas
Copy link
Member Author

jkotas commented Nov 12, 2020

Helps with dotnet/runtime#43079. It would be nice to make RemoteExecutor compatible with single file publishing eventually, but that would require more fundamental changes.

@jkotas
Copy link
Member Author

jkotas commented Nov 12, 2020

cc @ViktorHofer Remote executor compatibility with single file publishing is something to consider in the test infra plans you are thinking about.

Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@jkotas jkotas merged commit a1fe145 into dotnet:master Nov 12, 2020
@jkotas jkotas deleted the remoteexecutor-singlefile branch November 12, 2020 20:11
@MichalStrehovsky
Copy link
Member

It would be nice to make RemoteExecutor compatible with single file publishing eventually, but that would require more fundamental changes.

FWIW, there is a path to make RemoteExecutor compatible with single file - it was nuked in #4142. It includes RemoteExecutor support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants