Make XHarness CLI test fail the build #6503
Merged
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattGal
approved these changes
Nov 2, 2020
Member
MattGal
left a comment
MattGal
left a comment
There was a problem hiding this comment.
I definitely still see this failing:
https://dnceng.visualstudio.com/public/_build/results?buildId=871224&view=logs&j=50e98f4f-3b28-577a-6481-eda1b1f9a1d6&t=defe664d-8a62-56c3-6aa7-fef436596811
https://dnceng.visualstudio.com/public/_build/results?buildId=870013&view=logs&j=1116dead-7a8e-56c5-a64d-98b313fc00df&t=046196f3-b861-5d1f-cad5-503f80971ab2
but as long as you're monitoring it and willing to back the change out if something goes sideways, I am OK with it.
Member
Author
|
@MattGal I only fixed the machine today ^^ Merging.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This steps was failing because one of the machines didn't have
xcode-selectpointing to the Xcode installation but to the Xcode command line tools. That's why it only failed occasionally when it hit this one machine.I verified that this machine was the only one with this issue:
The step should fail the build and is stable otherwise.
Resolves dotnet/xharness#337
Error message improved here dotnet/xharness#349