Fix asynchronous nuget push and other bugs #6500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mmitche
commented
Oct 30, 2020
mmitche
commented
- Somehow the async nuget push got lost at some point. This resolves this by asynchronously waiting for process exit.
- Fixes an issue where we would log the output of all nuget failures even in non-failure cases, if another failure happened. The primary case for this is if a package push fails, but the file on the feed is the same as what we are pushing. This is not an error case, but if another operation in publishing fails, we'll erroneously log it.
- Fixes an issue where we would not log a package as succcesfully pushed if there was another error in publishing.
- Somehow the async nuget push got lost at some point. This resolves this by asynchronously waiting for process exit. - Fixes an issue where we would log the output of all nuget failures even in non-failure cases, if another failure happened. The primary case for this is if a package push fails, but the file on the feed is the same as what we are pushing. This is not an error case, but if another operation in publishing fails, we'll erroneously log it. - Fixes an issue where we would not log a package as succcesfully pushed if there was another error in publishing.
2 tasks
Member
Author
|
@ViktorHofer Fixes #6493 |
MattGal
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.