Skip to content

SymTargets: Add dependent target#4420

Merged
tmat merged 1 commit intodotnet:masterfrom
tmat:FixSymStore4
Nov 22, 2019
Merged

SymTargets: Add dependent target#4420
tmat merged 1 commit intodotnet:masterfrom
tmat:FixSymStore4

Conversation

@tmat
Copy link
Member

@tmat tmat commented Nov 22, 2019

No description provided.

Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@safern
Copy link
Member

safern commented Nov 22, 2019

I can build a package with this change and publish to a myget feed and test it on the failing PR if needed.

@tmat
Copy link
Member Author

tmat commented Nov 22, 2019

Actually, if you have a the repo checked out locally, you can just make the change in the restored arcade package on your machine and try the build.

@tmat tmat merged commit 6ade65a into dotnet:master Nov 22, 2019
@JoeRobich
Copy link
Member

We are still seeing errors during Roslyn builds in this mornings Arcade update (as we did with previous attempted updates this week). dotnet/roslyn#39965 - AzDO Build

  The system cannot find the path specified.
C:\Users\vsagent\.nuget\packages\microsoft.dotnet.arcade.sdk\5.0.0-beta.19571.10\tools\SymStore.targets(54,5): error MSB3073: The command ""C:\Users\vsagent\.nuget\packages\microsoft.diasymreader.pdb2pdb\1.1.0-beta1-62506-02\tools\Pdb2Pdb.exe" "F:\workspace\_work\1\s\artifacts\bin\Microsoft.CodeAnalysis\Release\netstandard2.0\Microsoft.CodeAnalysis.dll" /out "F:\workspace\_work\1\s\artifacts\SymStore\Release\Microsoft.CodeAnalysis\netstandard2.0\Microsoft.CodeAnalysis.pdb" /srcsvrvar SRC_INDEX=public" exited with code 3. [F:\workspace\_work\1\s\src\Compilers\Core\Portable\Microsoft.CodeAnalysis.csproj]

@tmat
Copy link
Member Author

tmat commented Nov 22, 2019

We'll get there, eventually: #4424 :-/
Tested Roslyn ci with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants