Skip to content

SymStore.targets target dependency fixes#4405

Merged
joperezr merged 2 commits intodotnet:masterfrom
tmat:SymStoreFix2
Nov 20, 2019
Merged

SymStore.targets target dependency fixes#4405
joperezr merged 2 commits intodotnet:masterfrom
tmat:SymStoreFix2

Conversation

@tmat
Copy link
Member

@tmat tmat commented Nov 20, 2019

No description provided.

@joperezr
Copy link
Member

FWIW I have validated that this fix does in fact fix the issue we were hitting in the IoT repo. Thanks for fixing @tmat

@safern
Copy link
Member

safern commented Nov 20, 2019

In the runtime repo this indeed fixes the issue. Just tried it (now with the -ci flag 😄 and validated that the symstore targets ran).

@joperezr
Copy link
Member

Merging to unblock runtime and iot PRs. Thanks for fixing @tmat

@joperezr joperezr merged commit 0644749 into dotnet:master Nov 20, 2019
@safern
Copy link
Member

safern commented Nov 21, 2019

@tmat this is still broken for the runtime repository but now it fails when running Pdb2Pdb.exe.

D:\a\1\s.packages\microsoft.dotnet.arcade.sdk\5.0.0-beta.19570.3\tools\SymStore.targets(64,5): error MSB3073: The command ""D:\a\1\s.packages\microsoft.diasymreader.pdb2pdb\1.1.0-beta2-19521-03\tools\Pdb2Pdb.exe" "D:\a\1\s\artifacts\bin\installer.tasks\Release\netstandard2.0\installer.tasks.dll" /out "D:\a\1\s\artifacts\SymStore\Release\installer.tasks\netstandard2.0\installer.tasks.pdb" /srcsvrvar SRC_INDEX=public" exited with code 3. [D:\a\1\s\tools-local\tasks\installer.tasks\installer.tasks.csproj]
##[error].packages\microsoft.dotnet.arcade.sdk\5.0.0-beta.19570.3\tools\SymStore.targets(64,5): error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=) The command ""D:\a\1\s.packages\microsoft.diasymreader.pdb2pdb\1.1.0-beta2-19521-03\tools\Pdb2Pdb.exe" "D:\a\1\s\artifacts\bin\installer.tasks\Release\netstandard2.0\installer.tasks.dll" /out "D:\a\1\s\artifacts\SymStore\Release\installer.tasks\netstandard2.0\installer.tasks.pdb" /srcsvrvar SRC_INDEX=public" exited with code 3.

https://dev.azure.com/dnceng/public/_build/results?buildId=433751&view=logs&jobId=7190fe20-9a4d-5ec6-b6bd-936671264aeb&taskId=2efa82f7-8523-5bc9-5322-0768c01fcfb7&lineStart=35&lineEnd=36&colStart=1&colEnd=471

@tmat
Copy link
Member Author

tmat commented Nov 21, 2019

ok, hopefully final fix: #4411
msbuild is fun! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants