Add support for relative paths in --projects for eng/common/build.sh#3910
Conversation
chcosta
left a comment
chcosta
left a comment
There was a problem hiding this comment.
I couldn't get this to work because of how bash parses ;s. Do you have a simple repro for how to make this work with multiple projects?
root@dfd18152e6f0:/src/arcade-docker2# ./build.sh -projects Arcade.sln\;Arcade2.sln
Updated projects: /src/arcade-docker2/Arcade.sln;/src/arcade-docker2/Arcade2.sln
MSBUILD : error MSB1006: Property is not valid.
Switch: /src/arcade-docker2/Arcade2.sln
For switch syntax, type "MSBuild -help"
Build failed (exit code '1').
root@dfd18152e6f0:/src/arcade-docker2# ./build.sh -projects 'Arcade.sln;Arcade2.sln'
Updated projects: /src/arcade-docker2/Arcade.sln;/src/arcade-docker2/Arcade2.sln
MSBUILD : error MSB1006: Property is not valid.
Switch: /src/arcade-docker2/Arcade2.sln
For switch syntax, type "MSBuild -help"
Build failed (exit code '1').
root@dfd18152e6f0:/src/arcade-docker2# ./build.sh -projects Arcade.sln;Arcade2.sln
Updated projects: /src/arcade-docker2/Arcade.sln
Could you get it to work prior to this change? I'd noted in my description this:
Even prior to this change, I couldn't get multiple projects to build (by supplying full paths). You can try supplying them within double-quotes, but I don't think that will help either. I was able to test the change with a single project though. |
|
Sounds good, I'll file an issue to follow up on this separately. Thanks @vatsan-madhavan |
|
Ping. Is this still something that we want to merge? |
|
why not - merging now :) |
|
This breaks using |
|
As a result, this is blocking coreclr's arcade uptake. |
|
and mono/linker. cc @marek-safar. cc @markwilkie seems we have a testhole here? |
|
Let's revert this to get Arcade uptake moving forward and we can look into bringing this back later. 😞 |
5 participants
PR in response to @tmat's comment at #3885 (comment).
I don't use OS X or Ubuntu regularly since WPF doesn't build on those ;-) I'm hoping that reviewers would take care to think about this submission very carefully before approving.
In practice, I don't think supplying multiple projects for
--projectsreally works inbuild.sh./cc @chcosta