Use Microsoft copyright#2635
Conversation
JohnTortugo
left a comment
JohnTortugo
left a comment
There was a problem hiding this comment.
Looks like this change might break somethings. Should we perhaps send an e-mail before?
| private static bool? IsMicrosoftLibrary(string copyright) | ||
| => copyright.Contains("Microsoft") ? true : copyright.Contains(".NET Foundation") ? null : (bool?)false; | ||
| private static bool IsMicrosoftLibrary(string copyright) | ||
| => copyright.Contains("Microsoft"); |
There was a problem hiding this comment.
Can't we do a full comparison with the copyright here?
There was a problem hiding this comment.
We can, but I think checking for Microsoft is sufficient.
There was a problem hiding this comment.
Given that NuGet requries letter-by-letter compliance it might be worthwhile actually doing that so we catch violations earlier.
| Override any other value the project may set. | ||
| --> | ||
| <PropertyGroup> | ||
| <Copyright>$(CopyrightMicrosoft)</Copyright> |
There was a problem hiding this comment.
Do we need to change this (https://github.com/dotnet/arcade/blob/master/Directory.Build.props#L6) as well or exclude it?
There was a problem hiding this comment.
This will override anything the repository sets. We can then stop setting it.
Remove copyright made redundant by dotnet/arcade#2635.
Remove copyright made redundant by dotnet/arcade#2635.
Remove copyright made redundant by dotnet/arcade#2635.
Remove copyright made redundant by dotnet/arcade#2635.
* Remove copyright made redundant by dotnet/arcade#2635.
3 participants
No description provided.