Apply CDN URL substitution to asset locations stored in BAR#16392
Merged
Apply CDN URL substitution to asset locations stored in BAR#16392
Conversation
Co-authored-by: mmitche <[email protected]>
Co-authored-by: mmitche <[email protected]>
Copilot
AI
changed the title
[WIP] Update asset locations to point to CDN after publishing
Apply CDN URL substitution to asset locations stored in BAR
Dec 9, 2025
mmitche
reviewed
Dec 10, 2025
| } | ||
| var authority = new Uri(feedBaseUrl).Authority; | ||
| if (AccountsWithCdns.TryGetValue(authority, out var replacementAuthority)) | ||
| if (PublishingConstants.AccountsWithCdns.TryGetValue(authority, out var replacementAuthority)) |
Member
There was a problem hiding this comment.
@copilot Because feedbaseUrl uses SafeTargetUrl, the additional replacement here is unnecessary
Contributor
Author
There was a problem hiding this comment.
You're absolutely right. Removed the redundant CDN substitution logic since SafeTargetURL already handles it. Fixed in 99fd736.
mmitche
reviewed
Dec 10, 2025
.nuget/nuget.exe
Outdated
Co-authored-by: mmitche <[email protected]>
Co-authored-by: mmitche <[email protected]>
mmitche
approved these changes
Dec 11, 2025
mmitche
approved these changes
Dec 11, 2025
akoeplinger
reviewed
Dec 11, 2025
akoeplinger
previously approved these changes
Dec 11, 2025
Co-authored-by: mmitche <[email protected]>
mmitche
approved these changes
Dec 11, 2025
akoeplinger
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asset locations stored in BAR for published blobs pointed to Azure storage URLs (e.g.,
dotnetbuilds.blob.core.windows.net/internal) which are only accessible via CDN. This made stored locations unusable.Changes
Centralized CDN mappings in
PublishingConstants.AccountsWithCdns:dotnetcli.blob.core.windows.net→builds.dotnet.microsoft.comdotnetbuilds.blob.core.windows.net→ci.dot.netEnhanced
TargetFeedConfig.SafeTargetURLto apply CDN substitution when generating asset locations for BAR storage usingUriBuilder.Hostproperty for clean URI manipulationSimplified
LatestLinksManager.ComputeLatestLinkBaseto remove redundant CDN substitution logic sinceSafeTargetURLalready handles itExample
Publishing to
https://dotnetbuilds.blob.core.windows.net/internal?sv=tokennow storeshttps://ci.dot.net/internalin BAR instead of the blob storage URL.To double check:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.