Conversation
|
Some other repos apply the condition where they set the flag: But I am OK with us doing this. I wonder if there is anyone, like NuGet for instance, that might have a default branch name that's not main. Can we make the condition be building in default branch? |
|
there's no good way to check what the default branch is. I don't think anyone currently enabling source-indexing is using a different name, my thinking was that if repo is using a different name they can just override the condition. |
|
Here's the list of repos indexed today -- https://github.com/dotnet/source-indexer/blob/3733d33b8050743a7034c3e2c10deb06c3a2b78d/src/index/repositories.props I think you're right, but I'd like to add more (like NuGet). I guess we just need to make sure they update the condition. I think we hadn't added NuGet in the past due to it building outside dnceng. I think we might need to do some work in azdo around permissions to let them publish to the source index's internal blob storage. |
|
/backport to release/10.0 |
|
Started backporting to |
|
/backport to release/9.0 |
|
Started backporting to |
|
@akoeplinger backporting to git am output$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Only run source index for main builds
Using index info to reconstruct a base tree...
M eng/common/core-templates/job/source-index-stage1.yml
Falling back to patching base and 3-way merge...
Auto-merging eng/common/core-templates/job/source-index-stage1.yml
CONFLICT (content): Merge conflict in eng/common/core-templates/job/source-index-stage1.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Only run source index for main builds
Error: The process '/usr/bin/git' failed with exit code 128 |
Backport of #16377 to release/9.0
Backport of #16377 to release/9.0
Set the default value for the condition to check for main branch, following what repos like wpf do: https://github.com/dotnet/wpf/blob/b0eef594c3cf95fed8d75e819c94f6eba65da826/eng/pipeline.yml#L25-L26
This also allows someone to override the condition if they want to.
Fixes an issue where servicing branches were running source indexing (and missing fixes like #16278).