Add property to opt-out of NuGet's implementation of restore#1633
Add property to opt-out of NuGet's implementation of restore#1633natemcmaster merged 1 commit intodotnet:masterfrom
Conversation
ViktorHofer
left a comment
There was a problem hiding this comment.
Thanks for giving us an option to opt-out.
|
Still my comment applies that I don't like that we are calling into internals of NuGet directly. |
It's less than ideal. Do you have an alternative solution to NuGet/Home#7648? |
I don't and I doubt that anyone outside of the NuGet team can easily fix that as it requires deep knowledge of how the dependency graph works. I'm fine with the hack for now I just wanted to raise my concern. |
|
I'm using a local build of this to verify that corefx works with this fix. The error I'm getting appears to be unrelated. Any ideas @ViktorHofer @safern ? |
|
No idea why you are hitting that error but it could be happening because you are testing with local bits. I took another look at the changes and I think they are safe. If the /p:Projects command now works fine I think we can merge this. |
|
Ok. Let's give this a shot. Let me know if it doesn't fix your issue. |
Follow-up to #1567
It appears the corefx repo, and perhaps others, do not actually use NuGet for their 'restore' target. #1567 broke these repos. This adds a property to opt-out of using NuGet.
cc @ViktorHofer @safern