Skip to content

Add property to opt-out of NuGet's implementation of restore#1633

Merged
natemcmaster merged 1 commit intodotnet:masterfrom
natemcmaster:corefx
Dec 19, 2018
Merged

Add property to opt-out of NuGet's implementation of restore#1633
natemcmaster merged 1 commit intodotnet:masterfrom
natemcmaster:corefx

Conversation

@natemcmaster
Copy link
Contributor

Follow-up to #1567

It appears the corefx repo, and perhaps others, do not actually use NuGet for their 'restore' target. #1567 broke these repos. This adds a property to opt-out of using NuGet.

cc @ViktorHofer @safern

@natemcmaster natemcmaster requested a review from tmat December 19, 2018 17:20
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for giving us an option to opt-out.

@ViktorHofer
Copy link
Member

Still my comment applies that I don't like that we are calling into internals of NuGet directly.

@natemcmaster
Copy link
Contributor Author

I don't like that we are calling into internals of NuGet directly.

It's less than ideal. Do you have an alternative solution to NuGet/Home#7648?

@ViktorHofer
Copy link
Member

Do you have an alternative solution to NuGet/Home#7648?

I don't and I doubt that anyone outside of the NuGet team can easily fix that as it requires deep knowledge of how the dependency graph works. I'm fine with the hack for now I just wanted to raise my concern.

@natemcmaster
Copy link
Contributor Author

I'm using a local build of this to verify that corefx works with this fix. The error I'm getting appears to be unrelated. Any ideas @ViktorHofer @safern ?

C:\Users\namc\.nuget\packages\microsoft.build.tasks.git\1.0.0-beta2-18618-05\build\Microsoft.Build.Tasks.Git.targets(20,5): error MSB4062: The "Microsoft.Build.Tasks.Git.LocateRepository" task could not be loaded from the assembly C:\Users\namc\.nuget\packages\microsoft.build.tasks.git\1.0.0-beta2-18618-05\build\..\tools\netcoreapp2.0\Microsoft.Build.Tasks.Git.dll. Assembly with same name is already loaded Confirm that the <UsingTask> declaration is correct, that
the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\src\dotnet\corefx\external\binplacePackages\binplacePackages.depproj]

https://github.com/natemcmaster/corefx/tree/validate-1633

@ViktorHofer
Copy link
Member

No idea why you are hitting that error but it could be happening because you are testing with local bits. I took another look at the changes and I think they are safe. If the /p:Projects command now works fine I think we can merge this.

@natemcmaster
Copy link
Contributor Author

Ok. Let's give this a shot. Let me know if it doesn't fix your issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants