Include AspNetCore.snk in StrongNameSignInfo#16106
Merged
Conversation
Co-authored-by: mmitche <[email protected]>
Co-authored-by: mmitche <[email protected]>
Copilot
AI
changed the title
[WIP] Include AspNetCore.snk in StrongNameSignInfo
Include AspNetCore.snk in StrongNameSignInfo
Sep 5, 2025
mmitche
approved these changes
Sep 5, 2025
akoeplinger
approved these changes
Sep 5, 2025
ellahathaway
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the AspNetCore strong name key to the default signing configuration in Sign.props, allowing assemblies signed with AspNetCore.snk to be automatically configured for signing without requiring users to manually add the key to their StrongNameSignInfo.
Changes Made
Added a new
StrongNameSignInfoentry insrc/Microsoft.DotNet.Arcade.Sdk/tools/Sign.props:The entry follows the same pattern as the existing
Open.snkentry and uses:$(MSBuildThisFileDirectory)snk\AspNetCore.snk(relative to the tools directory)adb9793829ddae60(verified against existing references in the codebase)Microsoft400(consistent with other entries)Validation
The public key token was verified by:
StrongName.targetsfile in the same repositorySignToolTests.csThis change enables repos using the AspNetCore strong name key to leverage the default Arcade signing infrastructure without additional configuration.
Fixes #16105.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
m8dvsblobprodcus37.vsblob.vsassets.io/home/REDACTED/work/arcade/arcade/.dotnet/dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:true /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=false /home/REDACTED/work/arcade/arcade/artifacts/toolset/restore.proj /t:__WriteToolsetLocation /clp:ErrorsOnly;NoSummary /p:__ToolsetLocationOutputFile=/home/REDACTED/work/arcade/arcade/artifacts/toolset/11.0.0-beta.25453.1.txt(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.