[WiX 5] Update LSS for localization#16036
Merged
joeloff merged 6 commits intodotnet:mainfrom Aug 13, 2025
Merged
Conversation
Member
Author
|
I'm testing a private build for the SDK to verify the LCGs for the .wxl files using v5 are correct. |
Member
Author
|
Needed to have mirrors in public and internal for testing this. Sample LCT |
Member
Author
|
Here's a link to a new LCG |
MiYanni
previously approved these changes
Aug 12, 2025
Co-authored-by: Michael Yanni <[email protected]>
Co-authored-by: Michael Yanni <[email protected]>
Co-authored-by: Michael Yanni <[email protected]>
MiYanni
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Schema for .wxl files changed in v5. OneLoc already has an updated settings file for the XML parser (210). We just need to include it in the generate localization project. See this workitem
Running locally, this now generates the following section
{ "LanguageSet": "VS_Main_Languages", "CloneLanguageSet": "WiX_CloneLanguages", "LocItems": [ { "SourceFile": ".\\Layout\\pkg\\windows\\bundles\\sdk\\LCID\\bundle.wxl", "CopyOption": "LangIDOnPath", "OutputPath": ".\\Layout\\pkg\\windows\\bundles\\sdk\\LCID\\" } ], "LssFiles": [ "P210WxlSchemaV4.lss" ] },Fixes #16039
Note: Having multiple LSS files is not supported. The change splits out the .wxl files into v3 and v5.