Migrate CreateBaselineUpdatePR to Microsoft.DotNet.Baselines.Tasks as MSBuild Task#16033
Migrate CreateBaselineUpdatePR to Microsoft.DotNet.Baselines.Tasks as MSBuild Task#16033ellahathaway merged 4 commits intodotnet:mainfrom
CreateBaselineUpdatePR to Microsoft.DotNet.Baselines.Tasks as MSBuild Task#16033Conversation
ViktorHofer
left a comment
ViktorHofer
left a comment
There was a problem hiding this comment.
Does this need to be in-built functionality inside the Arcade SDK or would it be sufficient to just use the package reference in consuming repos and get all the functionality via that?
Some scenarios can use a package reference in consuming repos, but others require running the task as a pipeline step. That’s why I added it to the Arcade SDK—so it can be easily invoked by the For example, in the license scanner pipeline, publishing the baselines PR has to happen in the pipeline, and cannot be integrated into the test's project file. This is because multiple license scanner jobs run in parallel, and their test results are merged to produce the updated baselines. In my opinion, putting this functionality in the Arcade SDK so that it can be invoked via |
| private readonly string _gitHubOrg; | ||
| private readonly string _gitHubRepoName; | ||
| private readonly GitHubClient _client; | ||
| private const string BuildLink = "https://dev.azure.com/dnceng/internal/_build/results?buildId="; |
There was a problem hiding this comment.
Should this link be configurable? The default is fine but I wonder whether this should be overridable.
There was a problem hiding this comment.
The tool is currently only used in internal dnceng builds, so I think the default is fine as-is. We can always make it configurable later if needed.
2 participants
This PR migrates the
CreateBaselineUpdatePRtool from the VMR to a new Arcade project, Microsoft.DotNet.Baselines.Tasks. It also refactors the tool from a command-line utility to a custom MSBuild task.The main advantage of this change is that it enables binlog generation when the task is invoked via the sdk-tasks script or included in a project (see dotnet/dotnet#4359). Additionally, moving the tool out of the VMR broadens its usability, making it possible to leverage this tooling outside the VMR context. For example, it could be used to update repo-specific exclusions files during official repo-level builds—such as sign check exclusions, if SignCheck adds support for updating exclusions baselines.
Note that I do not want to remove the original VMR tooling yet. That will have to be done after a rebootstrap that includes these changes.