Disable tests that require RSA+SHA-1 on platforms where RSA+SHA-1 is not available #15802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Green build on Alma Linux 9.5: |
Member
|
LGTM, but I'll let someone involved in SignTool have the checkmark authority. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request disables a handful of tests that exercise strong name signing for platforms that no longer support the cryptographic algorithm used in strong name signing.
Strong name signing depends on the use of RSA+SHA-1 digital signatures, as required by ECMA 335. However, some Linux distributions are starting to block the use of RSA+SHA-1 in their distribution's OpenSSL. Implementations of strong name signing that use .NET's
RSAfunctionality will be unable to sign or verify RSA+SHA-1 signatures on platforms that have explicitly chosen to disable it.Following a similar pattern that was done for
dotnet/runtime, this disables strong name tests on platforms that are unable to produce or verify RSA+SHA-1 signatures.Alma Linux 9 was identified as one of the impacted platforms at #15790.
/cc @richlander @mmitche