I think if I remember correctly it wasn't about having both files but referencing different versions. I'll try it out in runtime.

xunit.console isn't present under the runtime/artifacts directory.

@akoeplinger @ViktorHofer let me know if you want me to try something.

I think if I remember correctly it wasn't about having both files but referencing different versions

See dotnet/runtime#94183 (comment).

If you're copying the contents of xunit.console's NuGet package into your test output folder, you should stop doing that.

I thought that we fixed this in runtime. cc @ericstj

If you're copying the contents of xunit.console's NuGet package into your test output folder, you should stop doing that.

This is what is there:

$ ls xunit*.dll
xunit.abstractions.dll  xunit.core.dll              xunit.runner.reporters.netcoreapp10.dll  xunit.runner.visualstudio.testadapter.dll
xunit.assert.dll        xunit.execution.dotnet.dll  xunit.runner.utility.netcoreapp10.dll

The xunit.runner.*.dll are coming from xunit.runner.visualstudio/2.8.2.

@ViktorHofer I think that issue is a different one.

I did try this change in runtime and it indeed fails due to the net472 vs net462 TFM mismatch. I verified it does work in VS with the new package version though if we'd change the TFM to net472.

I pushed a change to only use the new version when TargetFrameworkIdentifier != .NETFramework.

Note that we'll have the same issue in the future if we upgrade to xunit v3 since it also targets net472.

Is this good to merge?

@ViktorHofer do you still want to go with the separate versions for the arcade defaults or should we just use the new version once dotnet/runtime#113667 is in?

I would consolidate the versions and then follow-up with the repos that have .NET Framework tests (at least the VMR repos).

Thank you for looking into this @ViktorHofer and @akoeplinger!