Skip to content

Fix DEB Conflicts property #15504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akoeplinger merged 1 commit into from
Feb 11, 2025
Merged

Fix DEB Conflicts property #15504

akoeplinger merged 1 commit into from
Feb 11, 2025

Conversation

@NikolaMilosavljevic
Copy link
Member

@NikolaMilosavljevic NikolaMilosavljevic commented Feb 11, 2025

dotnet-host Debian installer is failing to install with the following error:

dpkg: error processing archive dotnet-host-10.0.0-preview.2.25106.109-x64.deb (--install):
parsing file '/var/lib/dpkg/tmp.ci/control' near line 10 package 'dotnet-host':
'Conflicts' field, missing architecture name, or garbage where architecture name expected
Errors were encountered while processing:

This was introduced with new Debian packaging infra. Conflicts property is not evaluated correctly at

arcade/src/Microsoft.DotNet.Build.Tasks.Installers/build/installer.build.targets

Lines 233 to 239 in c80f519

<PropertyGroup>
<_ConflictsProperty Condition="'@(LinuxPackageConflicts)' != ''">Conflicts: @(LinuxPackageConflicts->'%(Identity)',', ')</_ConflictsProperty>
</PropertyGroup>
<ItemGroup>
<_ConflictsControlProperty Include="$(_ConflictsProperty)" />
</ItemGroup>
which then causes an extra : to be appended to the Conflicts value in control file. In case of dotnet-host, the value is: dotnet, dotnet-nightly:

Controls property gets added to Debian control file at

arcade/src/Microsoft.DotNet.Build.Tasks.Installers/src/CreateControlFile.cs

Line 74 in c80f519

writer.WriteLine($"{property.ItemSpec}: {property.GetMetadata("Value")}");

The fix is simple - I've tested the new package and it was installed without issues.

@NikolaMilosavljevic NikolaMilosavljevic requested review from a team and jkoritzinsky February 11, 2025 06:24
@akoeplinger akoeplinger merged commit 0b37fa0 into dotnet:main Feb 11, 2025
11 checks passed
@NikolaMilosavljevic NikolaMilosavljevic mentioned this pull request Feb 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NikolaMilosavljevic @akoeplinger @jkoritzinsky